Issue3819 mover model warnings #3830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit df5c22b.
sed -i 's/Added nominal curve specification to suppress warning./Specified <code>nominalValuesDefineDefaultPressureCurve=true<\/code>\nin the mover component to suppress a warning./g' $(find . -iname '*.mo')
* Moved models to Obsolete package, for #3604 * Issue3604 solar collectors (#3640) * Updated version to 12.0.0 --------- Co-authored-by: jelgerjansen <[email protected]> Co-authored-by: JayHuLBL <[email protected]>
|
@mwetter - With ibpsa/modelica-ibpsa#1879 merged, this branch is now synced with ibpsa master. |
This merges the IBPSA branch issue1883_solarCollectors
* Merge IBPSA master
This reverts commit df5c22b.
sed -i 's/Added nominal curve specification to suppress warning./Specified <code>nominalValuesDefineDefaultPressureCurve=true<\/code>\nin the mover component to suppress a warning./g' $(find . -iname '*.mo')
* Moved models to Obsolete package, for #3604 * Issue3604 solar collectors (#3640) * Updated version to 12.0.0 --------- Co-authored-by: jelgerjansen <[email protected]> Co-authored-by: JayHuLBL <[email protected]>
This merges the IBPSA branch issue1883_solarCollectors
* Merge IBPSA master
…-srg/modelica-buildings into issue3819_moverModelWarnings
|
It seems I totally messed up the commit history. The "changed files" shown on my local VS Code (looks fine with 23 changes) are different from shown on GitHub (hundreds). I will close this PR and make a fresh one for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #3819.
Models in the
Obsoletepackage are skipped.The following models are also skipped because they are planned to be obsoleted in a separate issue:
Buildings.Fluid.Movers.Validation.{PowerEuler,PowerExact,PowerSimplified}.